Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Add -ntosuru form #1393

Merged
merged 5 commits into from
Sep 5, 2024
Merged

[ja] Add -ntosuru form #1393

merged 5 commits into from
Sep 5, 2024

Conversation

khaitruong922
Copy link

No description provided.

@khaitruong922 khaitruong922 marked this pull request as ready for review September 4, 2024 03:58
@khaitruong922 khaitruong922 requested a review from a team as a code owner September 4, 2024 03:58
@khaitruong922
Copy link
Author

んと為る is not used (only 10 results when searching exact match on Google) so let's not match this variant.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1393 will not alter performance

Comparing khaitruong922:ntosuru (f0cc220) with master (3f7832f)

Summary

✅ 3 untouched benchmarks

🆕 2 new benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master khaitruong922:ntosuru Change
⁉️ japanese transformations (n=70) 20.8 ms N/A N/A
🆕 japanese transformations (n=72) N/A 18.5 ms N/A
⁉️ japanese transformations-full (n=193) 44.3 ms N/A N/A
🆕 japanese transformations-full (n=197) N/A 45.5 ms N/A

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Sep 4, 2024
@khaitruong922 khaitruong922 mentioned this pull request Sep 5, 2024
Merged
@Casheeew
Copy link
Member

Casheeew commented Sep 5, 2024

lgtm

@jamesmaa jamesmaa added this pull request to the merge queue Sep 5, 2024
Merged via the queue into yomidevs:master with commit aaa1617 Sep 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Casheeew Casheeew Casheeew approved these changes

Assignees
No one assigned
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khaitruong922 @Casheeew @jamesmaa @Kuuuube